[patch] [libcxx[ test suite temp file and __config fix

Howard Hinnant howard.hinnant at gmail.com
Sun Oct 6 14:19:57 PDT 2013

On Oct 4, 2013, at 11:22 AM, G M <gmisocpp at gmail.com> wrote:

> Hi Everyone / Howard / Reid
> Attached is a patch for the libcxx test suite. This patch does a few things.
> 1. It changes the temp file handling to use the template and the current directory for windows, matching how it works on other platforms.
> 2. It re-enables the temp file handling for mingw that regressed.

Parts 1 & 2 Committed revision 192073.

Part 3 not committed because of Marshall's comments.  It is possible to remove the #include <__config>, but not in the way this patch does.  *Some* libc++ header must be included prior to testing _LIBCPP_STD_VER > 11.


> 3. It removes the explicit inclusion of __config from a very minority number of recent-ish files that explicitly include it.
> __config is always implicitly included in the other test cases by other headers and it is inconsistent to do otherwise for the few changed in the patch.
> Making it implicit has the advantage that the test cases can be compiled by other compilers which can be useful in testing those compilers and using those compilers to verify if the test cases themselves have all the right dependencies.
> Howard, we may want to change testit to include __config implicitly on the command line so that it is included before code in test\support like platform_support.h. i.e. -include /libcxx/include/__config, but this patch does not make that change.
> Thanks
> <libcxx_test.diff>

More information about the cfe-commits mailing list