[PATCH] Fix PR17382 - properly group virtual method overloads in the vftable

Reid Kleckner rnk at google.com
Sun Oct 6 07:36:29 PDT 2013


  LGTM

  I was hoping the AST already had a clean way to iterate over related overloads in a class, but I guess not.


================
Comment at: lib/AST/VTableBuilder.cpp:2776
@@ +2775,3 @@
+  SmallVector<const CXXMethodDecl*, 10> VirtualMethods;
+  {
+    typedef SmallVector<const CXXMethodDecl *, 1> MethodGroup;
----------------
I'd make this block a helper, GroupMethodsByOverload or something.


http://llvm-reviews.chandlerc.com/D1839



More information about the cfe-commits mailing list