[PATCH] Added option to clang-format-diff.py to just output diff without changing files.

Alp Toker alp at nuanti.com
Fri Oct 4 13:28:05 PDT 2013

Thinking outside the box, it almost makes sense to have Alexander's mode
as the default for this tool because it already works in terms of
patches, then have -i to do an inplace update if requested.

I like the semantics of diff-in-diff-out and it avoids the question of
what to call the new flag, but it would be a breaking change. Of course
since there are no tests, it wouldn't technically be breaking anything ;-)


On 04/10/2013 21:02, Daniel Jasper wrote:
> ================
> Comment at: tools/clang-format/clang-format-diff.py:40
> @@ -36,1 +39,3 @@
>                                     'Reformat changed lines in diff.')
> +  parser.add_argument('-n', action='store_true', default=False,
> +                      help='don\'t change files, instead display what diffs'
> ----------------
> Why "-n" is there precedence in other tools? Otherwise, how about a named parameter? Maybe --dry_run?
> Or maybe two parameters "--dry_run" (do not apply changes) and "-v" (display diffs)?
> http://llvm-reviews.chandlerc.com/D1840
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

the browser experts

More information about the cfe-commits mailing list