[patch] [libcxx[ test suite temp file and __config fix

G M gmisocpp at gmail.com
Fri Oct 4 08:22:08 PDT 2013

Hi Everyone / Howard / Reid

Attached is a patch for the libcxx test suite. This patch does a few things.

1. It changes the temp file handling to use the template and the current
directory for windows, matching how it works on other platforms.
2. It re-enables the temp file handling for mingw that regressed.
3. It removes the explicit inclusion of __config from a very minority
number of recent-ish files that explicitly include it.

__config is always implicitly included in the other test cases by other
headers and it is inconsistent to do otherwise for the few changed in the

Making it implicit has the advantage that the test cases can be compiled by
other compilers which can be useful in testing those compilers and using
those compilers to verify if the test cases themselves have all the right

Howard, we may want to change testit to include __config implicitly on the
command line so that it is included before code in test\support like
platform_support.h. i.e. -include /libcxx/include/__config, but this patch
does not make that change.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131005/1a4c46b7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libcxx_test.diff
Type: application/octet-stream
Size: 6689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131005/1a4c46b7/attachment.obj>

More information about the cfe-commits mailing list