[libcxxabi][PATCH] unwinder

Dmitri Gribenko gribozavr at gmail.com
Thu Oct 3 10:47:50 PDT 2013

On Thu, Oct 3, 2013 at 10:36 AM, Nick Kledzik <kledzik at apple.com> wrote:
> Years ago Apple wrote its own unwinder for MacOSX and iOS.  To make libcxxabi complete, Apple has decided the source code for its unwinder can be contributed to the open source LLVM libcxxabi project, with a dual licensed under LLVM and MIT license.

Great news!

> So, I’ve spent some time cleaning up the sources to make them conform with LLVM style

Not a review, just style comments:
- please use three slashes for documentation comments that come before
function declarations/definitions
- some files contain tabs (for example, src/Unwind/config.h)
- some files contain trailing whitespace
- src/Unwind/UnwindRegistersRestore.s has some broken ASCII art


(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/

More information about the cfe-commits mailing list