[PATCH][StaticAnalyser] Replace magic strings for bug category with constant

Daniel Marjamäki Daniel.Marjamaki at evidente.se
Wed Oct 2 11:27:12 PDT 2013


Hello!

Based on previous reviews on other patches I created this patch.

This replaces magic strings for bug categories with constants.

As far as I see all tests runs fine (if the string categories::LogicError is replaced to anything other than "Logic error" there are assertions).

There is a minor change in behaviour. In CheckSizeofPointer.cpp the bug category is changed from "Logic" to "Logic error". Other than this.. there should be no change in behaviour anywhere.

Best regards,
Daniel Marjamäki

..................................................................................................................
Daniel Marjamäki Senior Engineer
Evidente ES East AB  Warfvinges väg 34  SE-112 51 Stockholm  Sweden

Mobile:                 +46 (0)709 12 42 62
E-mail:                 Daniel.Marjamaki at evidente.se

www.evidente.se
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commonbugcategories.diff
Type: text/x-patch
Size: 4229 bytes
Desc: commonbugcategories.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131002/2f2986ae/attachment.bin>


More information about the cfe-commits mailing list