[PATCH] Remove #include <windows.h> from libcxx/include/support/win32/support.h

G M gmisocpp at gmail.com
Wed Oct 2 06:32:31 PDT 2013

Hi Yaron

Yes that's true. Windows.h isn't required any more for clang or visual
studio builds either.

I didn't remove it in my prior patch to support.h because I was trying to
keep my changes minimal for the goal of that patch and remove windows.h in
a follow up one as it makes a big difference to compile times, especially
Visual Studio and curiously reduces the error count too.

I think these lines are also related to windows.h
//#ifndef NOMINMAX
//#define NOMINMAX
but min/max might get brought in by other Win32 headers, I'm not sure. It's
arguable that this macro should be defined in __config in the Win32 section
so it becomes project wide. libcxx goes to some lengths to avoid other
min/max issues in (some) other headers in using __undef_min_max.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131003/9a1d1248/attachment.html>

More information about the cfe-commits mailing list