r191653 - Add a bunch of other GCC '-f' options and ignore them. This covers every

[Richard Smith]

On Mon, Sep 30, 2013 at 12:46 AM, Chandler Carruth <chandlerc at gmail.com>wrote:

> Author: chandlerc
> Date: Mon Sep 30 02:46:08 2013
> New Revision: 191653
>
> URL: http://llvm.org/viewvc/llvm-project?rev=191653&view=rev
> Log:
> Add a bunch of other GCC '-f' options and ignore them. This covers every
> such option I've been able to find in the wild in our build system.
>
> Note that I haven't added test cases for this. I can do so if folks
> want, but they're *really* boring considering that this is all generated
> code to parse and ignore unsued options.
>

I don't think these are quite right:

-ffunction-attribute-list, -finline-limit, -ftls-model, and
-ftree-vectorizer-verbose need an "=argument" in GCC, and are rejected
without. This patch seems to reject them with the argument but accept them
without.

-fprofile-generate-sampling and -fprofile-reusedist are only accepted by
the google branch of GCC, as far as I can see. Maybe that's fine, though --
I understand various groups use compilers built from that branch.

I can't find any GCC (neither trunk nor google branch) that accepts -fgnu
nor -fprintf. Maybe these are typos in the relevant build rules?

-fspec-constr-count and -fregs-graph are GHC options, not GCC options.

Modified:
>     cfe/trunk/include/clang/Driver/Options.td
>
> Modified: cfe/trunk/include/clang/Driver/Options.td
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=191653&r1=191652&r2=191653&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/Driver/Options.td (original)
> +++ cfe/trunk/include/clang/Driver/Options.td Mon Sep 30 02:46:08 2013
> @@ -1381,20 +1381,37 @@

[...]

> -defm sse : BooleanFFlag<"see">, Group<clang_ignored_f_Group>;


GCC does actually accept "-fsee", and ignores it. (This defm had a typo in
its name, though.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130930/581e622d/attachment.html>