[PATCH] Implement aarch64 neon instruction class AdvSIMD (by	element) - LLVM
    Tim Northover 
    t.p.northover at gmail.com
       
    Sun Sep 29 10:52:37 PDT 2013
    
    
  
Hi Jiangning,
Sorry I didn't get a chance to reply on Friday, and thanks for
reworking the patch.
>   For register definition 'Re', I didn't make change.
Fair enough.
I think it looks pretty much OK now, though I'd be happier if there
was a test that we *weren't* generating fmla instructions all the time
(perhaps with a comment about it being intentional). It's a very
tempting "optimisation" to make.
I think you should commit, with or without that though. I'll take a
look over the revision after-wards.
Cheers.
Tim.
    
    
More information about the cfe-commits
mailing list