r191531 - Fix the test files by removing the unnecessary -emit-llvm flag (should address Matt Beaumont-Gay's concern regarding failure on a read-only filesystem)

[Faisal Vali]

I don't test IRGen in these files - not sure why i had -emit-llvm to begin
with (might be a hold over from a testing strategy i had used on windows
that was checking printed output which I was asked to abandon).

Not sure if it's all right to not include any IRGen tests as part of this
patch.  If someone has a strong opinion on this I can get around to IRGen
tests eventually.




Faisal Vali



On Fri, Sep 27, 2013 at 1:50 PM, Jordan Rose <jordan_rose at apple.com> wrote:

> That does mean we're not testing IRGen for these tests, though. Is that
> all right?
>
> (The portable equivalent of "-o /dev/null" might also work. We have one
> somewhere in lit.)
>
>
> On Sep 27, 2013, at 9:45 , Faisal Vali <faisalv at yahoo.com> wrote:
>
> > Author: faisalv
> > Date: Fri Sep 27 11:45:48 2013
> > New Revision: 191531
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=191531&view=rev
> > Log:
> > Fix the test files by removing the unnecessary -emit-llvm flag (should
> address Matt Beaumont-Gay's concern regarding failure on a read-only
> filesystem)
> >
> > Modified:
> >
>  cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp
> >
>  cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/p5-generic-lambda-1y.cpp
> >
> > Modified:
> cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp?rev=191531&r1=191530&r2=191531&view=diff
> >
> ==============================================================================
> > ---
> cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp
> (original)
> > +++
> cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/generic-lambda-unimplemented-1y.cpp
> Fri Sep 27 11:45:48 2013
> > @@ -1,4 +1,4 @@
> > -// RUN: %clang_cc1 -fsyntax-only -std=c++1y %s -verify -emit-llvm
> > +// RUN: %clang_cc1 -fsyntax-only -std=c++1y %s -verify
> > namespace return_type_deduction_ok {
> >  auto l = [](auto a) ->auto { return a; }(2);
> >  auto l2 = [](auto a) ->decltype(auto) { return a; }(2);
> >
> > Modified:
> cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/p5-generic-lambda-1y.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/p5-generic-lambda-1y.cpp?rev=191531&r1=191530&r2=191531&view=diff
> >
> ==============================================================================
> > ---
> cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/p5-generic-lambda-1y.cpp
> (original)
> > +++
> cfe/trunk/test/CXX/expr/expr.prim/expr.prim.lambda/p5-generic-lambda-1y.cpp
> Fri Sep 27 11:45:48 2013
> > @@ -1,4 +1,4 @@
> > -// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++1y -DCXX1Y
> -emit-llvm
> > +// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++1y -DCXX1Y
> >
> > namespace test_factorial {
> >
> > @@ -70,7 +70,6 @@ int test2() {
> >   {
> >     auto L = [](auto *a) {
> >                 return (*a)(a); }; //expected-error{{called object type
> 'double' is not a function}}
> > -    //l(&l);
> >     double d;
> >     L(&d); //expected-note{{in instantiation of}}
> >     auto M = [](auto b) { return b; };
> > @@ -79,7 +78,6 @@ int test2() {
> >   {
> >     auto L = [](auto *a) ->decltype (a->foo()) {
> //expected-note2{{candidate template ignored:}}
> >                 return (*a)(a); };
> > -    //l(&l);
> >     double d;
> >     L(&d); //expected-error{{no matching function for call}}
> >     auto M = [](auto b) { return b; };
> > @@ -118,8 +116,6 @@ namespace nested_lambdas {
> >                            return a + b;
> >                         };
> >               };
> > -   // auto M = L(3.14);
> > -   // return M('4');
> >   }
> >   auto get_lambda() {
> >     return [](auto a) {
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130927/aef0fa3c/attachment.html>