[PATCH] Implements Parts of Intrin.h

Reid Kleckner rnk at google.com
Fri Sep 27 11:24:39 PDT 2013


  I'd like to do some form of testing, but I don't feel like the other test/CodeGen/builtin*.c tests are very useful.


================
Comment at: lib/Headers/Intrin.h:349
@@ +348,3 @@
+\*----------------------------------------------------------------------------*/
+static __inline__ unsigned char __attribute__((__always_inline__, __nodebug__))
+_rotl8(unsigned char _Value, unsigned char _Shift) {
----------------
This file by itself shouldn't first declare these non-static and then make then static, inline, always_inline.  You may want to combine the decl and definition.


http://llvm-reviews.chandlerc.com/D1766



More information about the cfe-commits mailing list