r191523 - Abstract out the emission of vtables, add basic support for vtable emission when using -cxx-abi microsoft

[jahanian]

On Sep 27, 2013, at 10:01 AM, jahanian <fjahanian at apple.com> wrote:

> 
> On Sep 27, 2013, at 9:50 AM, Charles Davis <cdavis5x at gmail.com> wrote:
> 
>> 
>> On Sep 27, 2013, at 10:40 AM, jahanian wrote:
>> 
>>> 
>>> On Sep 27, 2013, at 8:53 AM, jahanian <fjahanian at apple.com> wrote:
>>> 
>>>> This patch causes a test failure in a win64 buildbot.
>>>> 
>>>> C:\public\win64\src\tools\clang\test\CodeGenCXX\microsoft-abi-multiple-nonvirtual-inheritance.cpp:165:12: error: expected string not found in input
>>>>    // CHECK: %[[VFPTR:.*]] = bitcast %struct.ChildOverride* %this1 to [1 x i8*]**
>>>                                                                                                                       [[THIS]]
>> He's trying to tell you that it won't have that name outside of a +Asserts build, so you need to use a FileCheck variable to match the name of the this pointer value.
> 
> Oops yes. Email was sent out prematurely sorry.  This is a suspect. But it does not work for me on my machine for some reason.

Actually replacing it with %[[THIS]] it two places fixes the test. 

- Fariborz

> 
> - Fariborz
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130927/822ec41c/attachment.html>