[PATCH] Emit Clang version information into .comment section (Clang's part of implementation) [PART 1]
Rafael Ávila de Espíndola
rafael.espindola at gmail.com
Thu Sep 26 10:03:51 PDT 2013
LGTM with these changes.
================
Comment at: lib/CodeGen/CodeGenModule.h:1097
@@ +1096,3 @@
+ /// \brief Emit the Clang version as llvm.ident metadata.
+ void EmitVersionIdentMetadata();
+
----------------
Start function names with lowercase please:
http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
================
Comment at: test/Driver/ident_md.c:5
@@ +4,3 @@
+// CHECK: !llvm.ident = !{!0}
+// CHECK: !0 = metadata !{metadata !"clang version
+
----------------
You might want to add a {{.*}} in case CLANG_VENDOR is defined.
http://llvm-reviews.chandlerc.com/D1720
More information about the cfe-commits
mailing list