[PATCH] [ms-cxxabi] Fix the calling convention for operator new in records

Eli Friedman eli.friedman at gmail.com
Wed Sep 25 17:00:44 PDT 2013


Please refactor the "declarator declares a static member" check so the code
is only in one place.

-Eli

On Wed, Sep 25, 2013 at 4:53 PM, Reid Kleckner <rnk at google.com> wrote:

> Hi rsmith,
>
> Operator new, new[], delete, and delete[] are all implicitly static when
> declared inside a record.  CXXMethodDecl already knows this, but we need
> to account for that before we pick the calling convention for the
> function type.
>
> Fixes PR17371.
>
> http://llvm-reviews.chandlerc.com/D1761
>
> Files:
>   include/clang/AST/DeclCXX.h
>   include/clang/Sema/Sema.h
>   lib/AST/DeclCXX.cpp
>   lib/AST/MicrosoftMangle.cpp
>   lib/Sema/SemaDecl.cpp
>   lib/Sema/SemaType.cpp
>   test/CodeGenCXX/mangle-ms.cpp
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130925/1a5b7bd8/attachment.html>


More information about the cfe-commits mailing list