PATCH: (kind of) to improve support for libc++ with libsupc++
Howard Hinnant
howard.hinnant at gmail.com
Wed Sep 25 12:23:44 PDT 2013
On Sep 25, 2013, at 1:43 PM, Chandler Carruth <chandlerc at google.com> wrote:
> It appears that there is file in libc++ whose entire contents are provided by libc++abi / libcxxrt / libsupc++:
>
> src/typeinfo.cpp
> --------
> ...
> #if !(defined(_LIBCPPABI_VERSION) || defined(LIBCXXRT))
> ...
> #endif
> --------
>
> So, only headers are included before the #if. So for users of libc++abi and libcxxrt, this translation unit is empty.
>
> For users of libsupc++, the symbols defined here produce link errors as they are always provided by libsupc++.
>
> Any objections to my deleting this file?
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Yes, I object. Please do not delete libcxx/src/typeinfo.cpp at this time. This file is still in active use. Instead #ifdef out any offending symbols.
Thanks,
Howard
More information about the cfe-commits
mailing list