[clang-tools-extra] r191308 - Clean up timing command line option.

Ariel J. Bernal ariel.j.bernal at intel.com
Tue Sep 24 08:41:30 PDT 2013


Author: ajbernal
Date: Tue Sep 24 10:41:30 2013
New Revision: 191308

URL: http://llvm.org/viewvc/llvm-project?rev=191308&view=rev
Log:
Clean up timing command line option.

Use getNumOccurrences instead of usina a default constant string.

Modified:
    clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp

Modified: clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp?rev=191308&r1=191307&r2=191308&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp (original)
+++ clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp Tue Sep 24 10:41:30 2013
@@ -93,11 +93,10 @@ static cl::opt<bool>
 SummaryMode("summary", cl::desc("Print transform summary"),
             cl::init(false));
 
-const char NoTiming[] = "no_timing";
 static cl::opt<std::string> TimingDirectoryName(
     "perf", cl::desc("Capture performance data and output to specified "
                      "directory. Default: ./migrate_perf"),
-    cl::init(NoTiming), cl::ValueOptional, cl::value_desc("directory name"));
+    cl::ValueOptional, cl::value_desc("directory name"));
 
 static cl::opt<std::string>
 IncludePaths("include",
@@ -384,9 +383,8 @@ int main(int argc, const char **argv) {
     return 1;
   }
 
-  // Since ExecutionTimeDirectoryName could be an empty string we compare
-  // against the default value when the command line option is not specified.
-  GlobalOptions.EnableTiming = (TimingDirectoryName != NoTiming);
+  // Enable timming.
+  GlobalOptions.EnableTiming = TimingDirectoryName.getNumOccurrences() > 0;
 
   // Check the reformatting style option
   bool CmdSwitchError = false;





More information about the cfe-commits mailing list