[PATCH][StaticAnalyzer] new check comparing equal expression

[Daniel Marjamäki]

Hello!

Thank you very much for commenting.

> Nice! This is a subset of http://llvm.org/PR9952 (except it's done in the analyzer).

I am working on Clang together with Per and Anders.

I am sorry.. I didn't see the work-in-progress for this. I believe the work-in-progress patch looks interesting.

I have discussed this diagnose and was recommended that this diagnose is put in the static analyzer to begin with so it could be tried out.
For 2 reasons:
 * It is possibly a bit cpu expensive since it's parsing subexpressions recursively.
 * The signal noise is not fully known, having it in the static analyzer means people get the feeling about this.

It is true that this patch seems to be a subset. It is intended to be a start. We intentionally didn't include && and || to start with. If this checker is added it can be extended so it handles more operators later.

> +Hans, since he has looked at this in the past.

I wonder if Hans wants to continue his excellent work or if we can continue.

Best regards,
Daniel Marjamäki

..................................................................................................................
Daniel Marjamäki
Senior Engineer
Evidente ES East AB 
Warfvinges väg 34  SE-112 51 Stockholm  Sweden 

Mobile:                
+46 (0)709 12 42 62
E-mail:   
Daniel.Marjamaki at evidente.se 
www.evidente.se