r190909 - Add comment about exporting clang::driver::ArgStringList,
Hans Wennborg
hans at hanshq.net
Tue Sep 17 17:41:15 PDT 2013
Author: hans
Date: Tue Sep 17 19:41:15 2013
New Revision: 190909
URL: http://llvm.org/viewvc/llvm-project?rev=190909&view=rev
Log:
Add comment about exporting clang::driver::ArgStringList,
as suggested by Jordan on IRC. Also, use the unqualified name
in Job.cpp.
And while we're here, refer to StringRef with the unqualified
name, because we have a using directive for that too.
Modified:
cfe/trunk/include/clang/Driver/Job.h
cfe/trunk/lib/Driver/Job.cpp
Modified: cfe/trunk/include/clang/Driver/Job.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Job.h?rev=190909&r1=190908&r2=190909&view=diff
==============================================================================
--- cfe/trunk/include/clang/Driver/Job.h (original)
+++ cfe/trunk/include/clang/Driver/Job.h Tue Sep 17 19:41:15 2013
@@ -24,6 +24,7 @@ class Action;
class Command;
class Tool;
+// Re-export this as clang::driver::ArgStringList.
using llvm::opt::ArgStringList;
class Job {
Modified: cfe/trunk/lib/Driver/Job.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Job.cpp?rev=190909&r1=190908&r2=190909&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Job.cpp (original)
+++ cfe/trunk/lib/Driver/Job.cpp Tue Sep 17 19:41:15 2013
@@ -22,7 +22,7 @@ Job::~Job() {}
Command::Command(const Action &_Source, const Tool &_Creator,
const char *_Executable,
- const llvm::opt::ArgStringList &_Arguments)
+ const ArgStringList &_Arguments)
: Job(CommandClass), Source(_Source), Creator(_Creator),
Executable(_Executable), Arguments(_Arguments) {}
@@ -113,7 +113,7 @@ void Command::Print(raw_ostream &OS, con
OS << Terminator;
}
-int Command::Execute(const llvm::StringRef **Redirects, std::string *ErrMsg,
+int Command::Execute(const StringRef **Redirects, std::string *ErrMsg,
bool *ExecutionFailed) const {
SmallVector<const char*, 128> Argv;
Argv.push_back(Executable);
More information about the cfe-commits
mailing list