r190902 - Move using directive from Job.h to Job.cpp

Hans Wennborg hans at hanshq.net
Tue Sep 17 16:37:45 PDT 2013


Author: hans
Date: Tue Sep 17 18:37:44 2013
New Revision: 190902

URL: http://llvm.org/viewvc/llvm-project?rev=190902&view=rev
Log:
Move using directive from Job.h to Job.cpp

I don't think it belongs in the header, but seems handy in the .cpp file.

Modified:
    cfe/trunk/include/clang/Driver/Job.h
    cfe/trunk/lib/Driver/Job.cpp

Modified: cfe/trunk/include/clang/Driver/Job.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Job.h?rev=190902&r1=190901&r2=190902&view=diff
==============================================================================
--- cfe/trunk/include/clang/Driver/Job.h (original)
+++ cfe/trunk/include/clang/Driver/Job.h Tue Sep 17 18:37:44 2013
@@ -24,8 +24,6 @@ class Action;
 class Command;
 class Tool;
 
-using llvm::opt::ArgStringList;
-
 class Job {
 public:
   enum JobClass {

Modified: cfe/trunk/lib/Driver/Job.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Job.cpp?rev=190902&r1=190901&r2=190902&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Job.cpp (original)
+++ cfe/trunk/lib/Driver/Job.cpp Tue Sep 17 18:37:44 2013
@@ -15,14 +15,14 @@
 #include "llvm/Support/raw_ostream.h"
 #include <cassert>
 using namespace clang::driver;
+using llvm::opt::ArgStringList;
 using llvm::raw_ostream;
 using llvm::StringRef;
 
 Job::~Job() {}
 
 Command::Command(const Action &_Source, const Tool &_Creator,
-                 const char *_Executable,
-                 const llvm::opt::ArgStringList &_Arguments)
+                 const char *_Executable, const ArgStringList &_Arguments)
     : Job(CommandClass), Source(_Source), Creator(_Creator),
       Executable(_Executable), Arguments(_Arguments) {}
 
@@ -113,7 +113,7 @@ void Command::Print(raw_ostream &OS, con
   OS << Terminator;
 }
 
-int Command::Execute(const llvm::StringRef **Redirects, std::string *ErrMsg,
+int Command::Execute(const StringRef **Redirects, std::string *ErrMsg,
                      bool *ExecutionFailed) const {
   SmallVector<const char*, 128> Argv;
   Argv.push_back(Executable);





More information about the cfe-commits mailing list