r190834 - Address review comment on r189557.

Eli Friedman eli.friedman at gmail.com
Mon Sep 16 17:51:32 PDT 2013


Author: efriedma
Date: Mon Sep 16 19:51:31 2013
New Revision: 190834

URL: http://llvm.org/viewvc/llvm-project?rev=190834&view=rev
Log:
Address review comment on r189557.

We need to escape filenames the same way in InclusionRewriter whether
UseLineDirective is true or false.

Review comment from http://llvm.org/bugs/show_bug.cgi?id=17018#c2

Modified:
    cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp

Modified: cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp?rev=190834&r1=190833&r2=190834&view=diff
==============================================================================
--- cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp (original)
+++ cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp Mon Sep 16 19:51:31 2013
@@ -110,7 +110,9 @@ void InclusionRewriter::WriteLineInfo(co
   if (!ShowLineMarkers)
     return;
   if (UseLineDirective) {
-    OS << "#line" << ' ' << Line << ' ' << '"' << Filename << '"';
+    OS << "#line" << ' ' << Line << ' ' << '"';
+    OS.write_escaped(Filename);
+    OS << '"';
   } else {
     // Use GNU linemarkers as described here:
     // http://gcc.gnu.org/onlinedocs/cpp/Preprocessor-Output.html





More information about the cfe-commits mailing list