[PATCH] [-cxx-abi microsoft] Mangle user defined entry points properly

Timur Iskhodzhanov timurrrr at google.com
Fri Sep 13 01:41:16 PDT 2013



================
Comment at: lib/AST/MicrosoftMangle.cpp:74
@@ -72,1 +73,3 @@
 
+// Microsoft Visual C++ will never mangle some "standard" entry points
+// regardless of visibility or freestanding-ness.
----------------
Shorter to say "We shouldn't mangle some ..."

================
Comment at: lib/AST/MicrosoftMangle.cpp:250
@@ -232,4 +249,3 @@
 
-    // "main" is not mangled.
-    if (FD->isMain())
+    if (isUserDefinedEntryPoint(FD))
       return false;
----------------
Interesting - the isMain() is used in a few places in AST and Sema.

Shouldn't we change isMain() to ask the ABI instead?


http://llvm-reviews.chandlerc.com/D1670



More information about the cfe-commits mailing list