[PATCH] [-cxx-abi microsoft] Mangle declarations inside extern "C"

[Timur Iskhodzhanov]

  LGTM with two suggestions


================
Comment at: lib/AST/MicrosoftMangle.cpp:312
@@ -270,7 +311,3 @@
   FD = FD->getFirstDeclaration();
 
   // We should never ever see a FunctionNoProtoType at this point.
----------------
Why can't we just

  if (!Context.shouldMangleDeclName(FD)) {
    Out << '9';
    return
  }

here?

================
Comment at: test/CodeGenCXX/mangle-ms.cpp:5
@@ -39,2 +4,3 @@
 int a;
+// CHECK-DAG: @"\01?a@@3HA"
 
----------------
You might consider committing the CHECK -> CHECK-DAG change separately to have a clearer history and make it easier to revert your change if things go bad


http://llvm-reviews.chandlerc.com/D1655