Fwd: [PATCH] Attributes with enum arguments

[Richard Smith]

SemaDeclAttr:2450 is underindented
ClangAttrEmitter:988 is underindented

The writeConversion function you generate has undefined behavior if the
string is not a member of the enumeration (because -1 is not a
representable value in the enumeration type). How about using a
StringSwitch<Optional<EnumType> > ? (You could even return
Optional<EnumType> directly from ConvertStrToEnumType.)


On Tue, Sep 10, 2013 at 7:44 PM, Aaron Ballman <aaron at aaronballman.com>wrote:

> Ping
>
> On Fri, Sep 6, 2013 at 2:31 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
> > This patch causes tablegen to generate a StringSwitch for attributes
> > that contain enum args, mapping from the enumerant string to the
> > proper enumeration value.  It resolves inconsistencies between
> > diagnostics, and brings us one step closer to more generalized error
> > reporting for attributes.
> >
> > ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130911/3913cd0f/attachment.html>