[PATCH] PR16182 - Visit parameter declaration of implicitly declared copy assignment operator.

Manuel Klimek klimek at google.com
Wed Sep 11 04:21:22 PDT 2013


  lg for the testing side, with the grammar updates :)


================
Comment at: unittests/Tooling/RecursiveASTVisitorTest.cpp:158
@@ -146,1 +157,3 @@
 
+// Test RAV visits parameter variable declaration of implicit
+// copy assignment operator.
----------------
of *the* implicit?

================
Comment at: unittests/Tooling/RecursiveASTVisitorTest.cpp:165
@@ +164,3 @@
+  // same SourceLocation with its class declaration, so we match an empty name
+  // with class source location here.
+  Visitor.ExpectMatch("", 1, 7);
----------------
I'd say "with the class' source location"


http://llvm-reviews.chandlerc.com/D958



More information about the cfe-commits mailing list