r190385 - Generate code for the move assignment operator using memcpy, the same as we do

Nick Lewycky nicholas at mxc.ca
Mon Sep 9 22:14:39 PDT 2013


Author: nicholas
Date: Tue Sep 10 00:14:39 2013
New Revision: 190385

URL: http://llvm.org/viewvc/llvm-project?rev=190385&view=rev
Log:
Generate code for the move assignment operator using memcpy, the same as we do
for the copy assignment operator.

Added:
    cfe/trunk/test/CodeGenCXX/move-assignment.cpp
Modified:
    cfe/trunk/lib/CodeGen/CodeGenFunction.cpp

Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenFunction.cpp?rev=190385&r1=190384&r2=190385&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CodeGenFunction.cpp (original)
+++ cfe/trunk/lib/CodeGen/CodeGenFunction.cpp Tue Sep 10 00:14:39 2013
@@ -702,7 +702,8 @@ void CodeGenFunction::GenerateCode(Globa
     // clones the body of the function call operator (but is actually static).
     EmitLambdaStaticInvokeFunction(cast<CXXMethodDecl>(FD));
   } else if (FD->isDefaulted() && isa<CXXMethodDecl>(FD) &&
-             cast<CXXMethodDecl>(FD)->isCopyAssignmentOperator()) {
+             (cast<CXXMethodDecl>(FD)->isCopyAssignmentOperator() ||
+              cast<CXXMethodDecl>(FD)->isMoveAssignmentOperator())) {
     // Implicit copy-assignment gets the same special treatment as implicit
     // copy-constructors.
     emitImplicitAssignmentOperatorBody(Args);

Added: cfe/trunk/test/CodeGenCXX/move-assignment.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/move-assignment.cpp?rev=190385&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenCXX/move-assignment.cpp (added)
+++ cfe/trunk/test/CodeGenCXX/move-assignment.cpp Tue Sep 10 00:14:39 2013
@@ -0,0 +1,26 @@
+// RUN: %clang_cc1 -emit-llvm -std=c++11 -o - %s -triple x86_64-pc-linux-gnu | FileCheck %s
+
+struct A {
+  A &operator=(A&&);
+};
+
+struct B {
+  A a;
+  int i;
+  bool b;
+  char c;
+  long l;
+  float f;
+};
+
+void test1() {
+  B b1, b2;
+  b1 = static_cast<B&&>(b2);
+}
+
+// CHECK-LABEL: define {{.*}} @_ZN1BaSEOS_
+// CHECK: call {{.*}} @_ZN1AaSEOS_
+// CHECK-NOT: store
+// CHECK: call {{.*}}memcpy{{.*}}, i64 24
+// CHECK-NOT: store
+// CHECK: ret





More information about the cfe-commits mailing list