r190378 - clang-cl: use -fdiagnostics-format=msvc by default

[Hans Wennborg]

Author: hans
Date: Mon Sep  9 20:07:07 2013
New Revision: 190378

URL: http://llvm.org/viewvc/llvm-project?rev=190378&view=rev
Log:
clang-cl: use -fdiagnostics-format=msvc by default

This allows for navigating to errors within the MSVC IDE by clicking
on the diagnostics.

Modified:
    cfe/trunk/lib/Driver/Tools.cpp
    cfe/trunk/test/Driver/cl.c

Modified: cfe/trunk/lib/Driver/Tools.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=190378&r1=190377&r2=190378&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Tools.cpp (original)
+++ cfe/trunk/lib/Driver/Tools.cpp Mon Sep  9 20:07:07 2013
@@ -3757,6 +3757,11 @@ void Clang::AddClangCLArgs(const ArgList
 
   if (Arg *A = Args.getLastArg(options::OPT_show_includes))
     A->render(Args, CmdArgs);
+
+  if (!Args.hasArg(options::OPT_fdiagnostics_format_EQ)) {
+    CmdArgs.push_back("-fdiagnostics-format");
+    CmdArgs.push_back("msvc");
+  }
 }
 
 void ClangAs::ConstructJob(Compilation &C, const JobAction &JA,

Modified: cfe/trunk/test/Driver/cl.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl.c?rev=190378&r1=190377&r2=190378&view=diff
==============================================================================
--- cfe/trunk/test/Driver/cl.c (original)
+++ cfe/trunk/test/Driver/cl.c Mon Sep  9 20:07:07 2013
@@ -30,5 +30,6 @@
 // DEFAULT: -fapple-kext
 // CL-NOT: -fapple-kext
 
-// RUN: %clang_cl /c -### -- %s 2>&1 | FileCheck -check-prefix=ABI %s
-// ABI: "-cxx-abi" "microsoft"
+// RUN: %clang_cl /c -### -- %s 2>&1 | FileCheck -check-prefix=COMPILE %s
+// COMPILE: "-cxx-abi" "microsoft"
+// COMPILE: "-fdiagnostics-format" "msvc"