r190369 - Adding a FIXME based on feedback from Richard Smith.

[Aaron Ballman]

Author: aaronballman
Date: Mon Sep  9 18:40:31 2013
New Revision: 190369

URL: http://llvm.org/viewvc/llvm-project?rev=190369&view=rev
Log:
Adding a FIXME based on feedback from Richard Smith.

Modified:
    cfe/trunk/lib/Sema/SemaDeclAttr.cpp

Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclAttr.cpp?rev=190369&r1=190368&r2=190369&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclAttr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclAttr.cpp Mon Sep  9 18:40:31 2013
@@ -1549,6 +1549,9 @@ static void handleWeakRefAttr(Sema &S, D
   // static ((alias ("y"), weakref)).
   // Should we? How to check that weakref is before or after alias?
 
+  // FIXME: it would be good for us to keep the WeakRefAttr as-written instead
+  // of transforming it into an AliasAttr.  The WeakRefAttr never uses the
+  // StringRef parameter it was given anyway.
   if (Attr.isArgExpr(0)) {
     Expr *Arg = Attr.getArgAsExpr(0);
     Arg = Arg->IgnoreParenCasts();