r190054 - Fixes PR 17106 (explicitly typed enums are formatted differently).
Manuel Klimek
klimek at google.com
Thu Sep 5 08:34:56 PDT 2013
Author: klimek
Date: Thu Sep 5 10:34:55 2013
New Revision: 190054
URL: http://llvm.org/viewvc/llvm-project?rev=190054&view=rev
Log:
Fixes PR 17106 (explicitly typed enums are formatted differently).
Before:
enum X : int { A, B, C };
After:
enum X : int {
A,
B,
C
};
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/UnwrappedLineParser.cpp?rev=190054&r1=190053&r2=190054&view=diff
==============================================================================
--- cfe/trunk/lib/Format/UnwrappedLineParser.cpp (original)
+++ cfe/trunk/lib/Format/UnwrappedLineParser.cpp Thu Sep 5 10:34:55 2013
@@ -1035,9 +1035,7 @@ void UnwrappedLineParser::parseEnum() {
if (FormatTok->Tok.is(tok::kw_class) ||
FormatTok->Tok.is(tok::kw_struct))
nextToken();
- if (FormatTok->Tok.is(tok::identifier) ||
- FormatTok->Tok.is(tok::kw___attribute) ||
- FormatTok->Tok.is(tok::kw___declspec)) {
+ while (FormatTok->Tok.getIdentifierInfo() || FormatTok->Tok.is(tok::colon)) {
nextToken();
// We can have macros or attributes in between 'enum' and the enum name.
if (FormatTok->Tok.is(tok::l_paren)) {
Modified: cfe/trunk/unittests/Format/FormatTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=190054&r1=190053&r2=190054&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTest.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTest.cpp Thu Sep 5 10:34:55 2013
@@ -1573,6 +1573,13 @@ TEST_F(FormatTest, FormatsEnumClass) {
verifyFormat("enum class X f() {\n a();\n return 42;\n}");
}
+TEST_F(FormatTest, FormatsEnumTypes) {
+ verifyFormat("enum X : int {\n"
+ " A,\n"
+ " B\n"
+ "};");
+}
+
TEST_F(FormatTest, FormatsBitfields) {
verifyFormat("struct Bitfields {\n"
" unsigned sClass : 8;\n"
More information about the cfe-commits
mailing list