[PATCH] Adding LZMA as dep for XML2 on 2.8.0 or higher

Renato Golin renato.golin at linaro.org
Thu Sep 5 03:28:18 PDT 2013


LibXML2 config doesn't specify lzma as a dependency, which breaks cross-compilation builds using new linkers (ld 2.21 or higher).
    
There is a bug on libxml2 to fix that, but since it's going to take     a while for things to go round and back, so we should have a harmless addition of the library until then.

This breaks Clang's c-index-test cross-build.

http://llvm-reviews.chandlerc.com/D1604

Files:
  cmake/config-ix.cmake

Index: cmake/config-ix.cmake
===================================================================
--- cmake/config-ix.cmake
+++ cmake/config-ix.cmake
@@ -300,6 +300,10 @@
 find_package(LibXml2)
 if (LIBXML2_FOUND)
   set(CLANG_HAVE_LIBXML 1)
+  if (NOT PC_LIBXML_VERSION VERSION_LESS "2.8.0")
+    message(STATUS "Adding LZMA as a dep to XML2 until xml2-config gets fixed")
+    set(LIBXML2_LIBRARIES ${LIBXML2_LIBRARIES} "-llzma")
+  endif ()
 endif ()
 
 include(CheckCXXCompilerFlag)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1604.1.patch
Type: text/x-patch
Size: 486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130905/44e3d858/attachment.bin>


More information about the cfe-commits mailing list