[PATCH] Mark lambda closure classes as being implicitly-generated.

David Blaikie dblaikie at gmail.com
Wed Sep 4 15:12:31 PDT 2013


  Looks reasonable to me - enough that I'm willing to sign off on it and anyone else can object/discuss in post-commit review.


================
Comment at: unittests/Tooling/RecursiveASTVisitorTest.cpp:531
@@ +530,3 @@
+  bool VisitCXXRecordDecl(CXXRecordDecl* record) {
+    if (record->isLambda() && !record->isImplicit()) {
+      SawNonImplicitLambdaClass = true;
----------------
Unnecessary curlies (not sure if that's the local convention here, but not the LLVM convention generally)

& because I'm far too terse, I would, depending on the day, write this as "x |= y" rather than "if (y) x = true". But I don't really claim this is better.


http://llvm-reviews.chandlerc.com/D1593



More information about the cfe-commits mailing list