[PATCH] New FIXME text for Consumed Analysis
Christian Wailes
chriswailes at google.com
Tue Sep 3 14:28:11 PDT 2013
Hi delesley, aaron.ballman,
Updated some FIXME text to correctly describe the problem and what needs to be done to fix it.
http://llvm-reviews.chandlerc.com/D1588
Files:
test/SemaCXX/warn-consumed-parsing.cpp
Index: test/SemaCXX/warn-consumed-parsing.cpp
===================================================================
--- test/SemaCXX/warn-consumed-parsing.cpp
+++ test/SemaCXX/warn-consumed-parsing.cpp
@@ -6,8 +6,11 @@
#define RETURN_TYPESTATE(State) __attribute__ ((return_typestate(State)))
#define TESTS_UNCONSUMED __attribute__ ((tests_unconsumed))
-// FIXME: This warning is not generated if it appears bellow the AttrTester0
-// class declaration. Why?
+// FIXME: This test is here because the warning is issued by the Consumed
+// analysis, not SemaDeclAttr. The analysis won't run after an error
+// has been issued. Once the attribute propagation for template
+// instantiation has been fixed, this can be moved somewhere else and the
+// definition can be removed.
int returnTypestateForUnconsumable() RETURN_TYPESTATE(consumed); // expected-warning {{return state set for an unconsumable type 'int'}}
int returnTypestateForUnconsumable() {
return 0;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1588.1.patch
Type: text/x-patch
Size: 1015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130903/2d97a17c/attachment.bin>
More information about the cfe-commits
mailing list