[PATCH] Switch type used by FormatAttr

Eli Friedman eli.friedman at gmail.com
Tue Sep 3 13:28:06 PDT 2013


On Tue, Sep 3, 2013 at 1:03 PM, Aaron Ballman <aaron at aaronballman.com>wrote:

> The tablegen for the format attribute claims the first argument
> expected is a string.  However, the attribute actually takes an
> unresolved identifier instead of a string literal.  This patch
> clarifies that by making the attribute take an IdentifierArgument, and
> updates associated code.
>
> Since this is the only case where the parser was doing something
> special for StringArguments, I updated the tablegen emitter to remove
> complexity.
>
>
Is there any reason to not just make FormatAttr::getType() return an
IdentifierInfo?

Otherwise, looks fine.

-Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130903/590d8920/attachment.html>


More information about the cfe-commits mailing list