[PATCH] Remove useless reinterpret_casts from Stmt.cpp

[Rafael Espíndola]

LGTM

On 3 September 2013 10:21, Pavel Labath <labath at google.com> wrote:
> Hi rsmith,
>
> I have no idea why these were there in the first place, but now they are
> certainly not necessary.
>
> http://llvm-reviews.chandlerc.com/D1581
>
> Files:
>   lib/AST/Stmt.cpp
>
> Index: lib/AST/Stmt.cpp
> ===================================================================
> --- lib/AST/Stmt.cpp
> +++ lib/AST/Stmt.cpp
> @@ -706,7 +706,7 @@
>                                               SourceLocation RPL)
>  : Stmt(ObjCForCollectionStmtClass) {
>    SubExprs[ELEM] = Elem;
> -  SubExprs[COLLECTION] = reinterpret_cast<Stmt*>(Collect);
> +  SubExprs[COLLECTION] = Collect;
>    SubExprs[BODY] = Body;
>    ForLoc = FCL;
>    RParenLoc = RPL;
> @@ -790,8 +790,8 @@
>    : Stmt(CXXForRangeStmtClass), ForLoc(FL), ColonLoc(CL), RParenLoc(RPL) {
>    SubExprs[RANGE] = Range;
>    SubExprs[BEGINEND] = BeginEndStmt;
> -  SubExprs[COND] = reinterpret_cast<Stmt*>(Cond);
> -  SubExprs[INC] = reinterpret_cast<Stmt*>(Inc);
> +  SubExprs[COND] = Cond;
> +  SubExprs[INC] = Inc;
>    SubExprs[LOOPVAR] = LoopVar;
>    SubExprs[BODY] = Body;
>  }
> @@ -822,7 +822,7 @@
>    : Stmt(IfStmtClass), IfLoc(IL), ElseLoc(EL)
>  {
>    setConditionVariable(C, var);
> -  SubExprs[COND] = reinterpret_cast<Stmt*>(cond);
> +  SubExprs[COND] = cond;
>    SubExprs[THEN] = then;
>    SubExprs[ELSE] = elsev;
>  }
> @@ -853,8 +853,8 @@
>  {
>    SubExprs[INIT] = Init;
>    setConditionVariable(C, condVar);
> -  SubExprs[COND] = reinterpret_cast<Stmt*>(Cond);
> -  SubExprs[INC] = reinterpret_cast<Stmt*>(Inc);
> +  SubExprs[COND] = Cond;
> +  SubExprs[INC] = Inc;
>    SubExprs[BODY] = Body;
>  }
>
> @@ -881,7 +881,7 @@
>    : Stmt(SwitchStmtClass), FirstCase(0), AllEnumCasesCovered(0)
>  {
>    setConditionVariable(C, Var);
> -  SubExprs[COND] = reinterpret_cast<Stmt*>(cond);
> +  SubExprs[COND] = cond;
>    SubExprs[BODY] = NULL;
>  }
>
> @@ -914,7 +914,7 @@
>                       SourceLocation WL)
>    : Stmt(WhileStmtClass) {
>    setConditionVariable(C, Var);
> -  SubExprs[COND] = reinterpret_cast<Stmt*>(cond);
> +  SubExprs[COND] = cond;
>    SubExprs[BODY] = body;
>    WhileLoc = WL;
>  }
> @@ -986,7 +986,7 @@
>    : Stmt(SEHExceptStmtClass),
>      Loc(Loc)
>  {
> -  Children[FILTER_EXPR] = reinterpret_cast<Stmt*>(FilterExpr);
> +  Children[FILTER_EXPR] = FilterExpr;
>    Children[BLOCK]       = Block;
>  }
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>