[PATCH] Add clang-format VS extension

Manuel Klimek klimek at google.com
Sun Sep 1 12:24:18 PDT 2013


On Sun, Sep 1, 2013 at 5:34 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:

>
>   I built and tested this locally, and it works really well!
>
>   The Visual Studio SDK was necessary for building, thanks for the hint.
> Maybe add a README with info on prerequisites? The VS SDK for 2012 is
> available here:
>   http://www.microsoft.com/en-us/download/details.aspx?id=30668
>
>   Also, the SVN patch didn't carry the binary files Images.png and
> Package.ico, so I had to create dummy images, but that should work better
> from a proper checkout.
>
>   LGTM.
>
>
> ================
> Comment at: tools/clang-format-vs/ClangFormat/PkgCmdID.cs:2
> @@ +1,3 @@
> +// PkgCmdID.cs
> +// MUST match PkgCmdID.h
> +
> ----------------
> I find these comments confusing, I guess they came from a code generator?
>
> ================
> Comment at: tools/clang-format-vs/ClangFormat/Guids.cs:2
> @@ +1,3 @@
> +// Guids.cs
> +// MUST match guids.h
> +using System;
> ----------------
> I find these comments confusing, I guess they came from a code generator?
>

Yep, those comments are from the generators - do you think I should delete
all those generator-generated comments?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130901/7c4155b3/attachment.html>


More information about the cfe-commits mailing list