[libcxx] r189692 - [tests] Change with_system_lib feature to match what XFAIL lines expect.

Daniel Dunbar daniel at zuster.org
Fri Aug 30 12:52:12 PDT 2013


Author: ddunbar
Date: Fri Aug 30 14:52:12 2013
New Revision: 189692

URL: http://llvm.org/viewvc/llvm-project?rev=189692&view=rev
Log:
[tests] Change with_system_lib feature to match what XFAIL lines expect.

 - The lit builtin XFAIL handling is more restrictive than what we were
   previously using, and for now I'd rather keep the lit one restrictive.

Modified:
    libcxx/trunk/test/lit.cfg

Modified: libcxx/trunk/test/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/lit.cfg?rev=189692&r1=189691&r2=189692&view=diff
==============================================================================
--- libcxx/trunk/test/lit.cfg (original)
+++ libcxx/trunk/test/lit.cfg Fri Aug 30 14:52:12 2013
@@ -2,15 +2,16 @@
 
 # Configuration file for the 'lit' test runner.
 
+import errno
 import os
-import sys
 import platform
-import tempfile
+import re
+import shlex
 import signal
 import subprocess
-import errno
+import sys
+import tempfile
 import time
-import shlex
 
 import lit.Test
 import lit.formats
@@ -284,5 +285,8 @@ if config.target_triple is None:
 # known to fail with versions of libc++ as were shipped with a particular
 # triple.
 if use_system_lib:
-    config.available_features.add('with_system_lib=%s' % (
-            config.target_triple,))
+    # Drop sub-major version components from the triple, because the current
+    # XFAIL handling expects exact matches for feature checks.
+    sanitized_triple = re.sub(r"([^-]+)-([^-]+)-([^-.]+).*", r"\1-\2-\3",
+                              config.target_triple)
+    config.available_features.add('with_system_lib=%s' % (sanitized_triple,))





More information about the cfe-commits mailing list