[PATCH] [ms-cxxabi] Implement guard variables for static initialization

Chandler Carruth chandlerc at google.com
Fri Aug 30 11:10:02 PDT 2013


On Fri, Aug 30, 2013 at 10:45 AM, Reid Kleckner <rnk at google.com> wrote:

> I'm having a very hard time extracting this function from Sema and moving
> it over to AST/ItaniumCXXABI.cpp as John suggested.  It accesses a bunch of
> Sema fields.  Do you have any thoughts on how this should look in the long
> run?


Just throwing this out there, but this kind of a refactoring and
re-layering seems like a very reasonable thing to leave FIXME comments
about (even file a PR if needed) and fix in follow-up commits rather than
blocking other things on this change. Notably, not having any support for
this causes us to not get very far testing other functionality.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130830/bafea751/attachment.html>


More information about the cfe-commits mailing list