[PATCH] Fixing a bug where debug info for a local variable gets emitted at file scope

Eric Christopher echristo at gmail.com
Thu Aug 29 23:56:15 PDT 2013


Looks like we got 4 xpasses out of it so it might be already covered.
On Aug 29, 2013 10:50 PM, "David Blaikie" <dblaikie at gmail.com> wrote:

> On Thu, Aug 29, 2013 at 10:45 PM, Yunzhong Gao
> <Yunzhong_Gao at playstation.sony.com> wrote:
> >
> >   Committed the fix in r189649.
> >   http://llvm.org/viewvc/llvm-project?view=revision&revision=189649
>
> Thanks! (for both the patch & your patience in review)
>
> >
> >   Should I add tests to the debuginfo-tests repository as well? I wrote
> >   some tests here:
> >   http://llvm-reviews.chandlerc.com/D1280
>
> Personally I don't much like these end-to-end tests. There's value in
> full feature tests, to be sure, but this isn't exactly a complete
> suite - you might see if you could get them into the GDB test suite if
> there's nothing like that in there already & you're feeling
> exceptionally diligent. (at some point I'll need to port my GDB 7.5
> xfails, etc, up to GDB ToT & setup a Clang ToT + GDB ToT builder, but
> I haven't gotten around to it yet)
>
> >
> > http://llvm-reviews.chandlerc.com/D1281
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130829/07eb2b25/attachment.html>


More information about the cfe-commits mailing list