[PATCH] Bug 14984 - Implement __attribute__((ms_abi))

Richard Smith richard at metafoo.co.uk
Thu Aug 29 21:38:17 PDT 2013


On Thu, Aug 29, 2013 at 9:18 PM, Charles Davis <cdavis5x at gmail.com> wrote:

>
> On Aug 29, 2013, at 7:53 PM, Richard Smith wrote:
>
> On Thu, Aug 29, 2013 at 6:48 PM, Charles Davis <cdavis5x at gmail.com> wrote:
>
>>
>> On Aug 29, 2013, at 7:38 PM, Richard Smith wrote:
>>
>> On Thu, Aug 29, 2013 at 6:12 PM, Reid Kleckner <rnk at google.com> wrote:
>>
>>> On Thu, Aug 29, 2013 at 6:11 PM, Richard Smith <richard at metafoo.co.uk>wrote:
>>>
>>>> I'd prefer that the ms_abi and sysv_abi attributes are instead mapped
>>>> to different calling conventions on different targets (so we never use
>>>> CC_X86_64SysV in cases where it is the same as CC_C).
>>>>
>>>
>>> I believe the last patch implements that.
>>>
>>
>> Hmm, maybe I'm looking at the wrong patch then. The patch that I'm
>> looking at always maps AT_MSABI to CC_X86_64Win64, then does a fixup from
>> that to CC_C in checkCallingConvention for some targets.
>>
>> Heh. :)
>>
>> I think I know what he's talking about. Something like this, maybe?
>>
>
> Perfect =)
>
> Excellent! No further objections, I trust?
>

Not from me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130829/8b20a7eb/attachment.html>


More information about the cfe-commits mailing list