r189369 - Warn that -O4 is the same as -O3.

Sean Silva silvas at purdue.edu
Thu Aug 29 15:50:50 PDT 2013


On Tue, Aug 27, 2013 at 4:41 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> > Any reason not to remove this, and instead look at the argument to the
> OPT_O
> > option?
> >
> > (Likewise, why do we have a separate -O0 flag?)
>
> Just convenience. It is easier to write
>
> A->getOption().matches(options::OPT_O4)
>
> Than to check it matches OPT_O, get the value, check if it is integer and
> == 4.
>


Maybe we should warn for all integers >= 4 though.

-- Sean Silva


>
> Cheers,
> Rafael
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130829/3664d88f/attachment.html>


More information about the cfe-commits mailing list