[PATCH] Mostly correct conditional handling for Consumed analysis

Delesley Hutchins delesley at google.com
Thu Aug 29 10:30:53 PDT 2013


Committed as r189594.

  -DeLesley

On Wed, Aug 28, 2013 at 7:14 PM, Christian Wailes
<chriswailes at google.com> wrote:
>   Fixed a bug involving invertConsumedUnconsumed.
>
>   VisitBinaryTest wasn't initializing TestsFor in empty tests.  This is fine now, as it would never be accessed again later.  It could be a problem in future code though.  Due to the lack of initialization the function fell off the end of the switch and hit an illegal instruction in debug mode, causing the unit test to fail.
>
> Hi delesley, dblaikie, aaron.ballman,
>
> http://llvm-reviews.chandlerc.com/D1501
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D1501?vs=3878&id=3882#toc
>
> Files:
>   include/clang/Analysis/Analyses/Consumed.h
>   lib/Analysis/Consumed.cpp
>   test/SemaCXX/warn-consumed-analysis-strict.cpp
>   test/SemaCXX/warn-consumed-analysis.cpp



-- 
DeLesley Hutchins | Software Engineer | delesley at google.com | 505-206-0315




More information about the cfe-commits mailing list