r189575 - Removed useless default branch of switch statement.

David Blaikie dblaikie at gmail.com
Thu Aug 29 08:18:58 PDT 2013


On Thu, Aug 29, 2013 at 1:20 AM, Serge Pavlov <sepavloff at gmail.com> wrote:
> Author: sepavloff
> Date: Thu Aug 29 03:20:07 2013
> New Revision: 189575
>
> URL: http://llvm.org/viewvc/llvm-project?rev=189575&view=rev
> Log:
> Removed useless default branch of switch statement.
> The problem was caught by sanitizer build.

Caught in what way? I'm not sure how any of the sanitizers would help
with this specific issue. Was this just a -Wcovered-switch-default
warning/break?

>
> Modified:
>     cfe/trunk/lib/Sema/SemaLookup.cpp
>
> Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaLookup.cpp?rev=189575&r1=189574&r2=189575&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Sema/SemaLookup.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaLookup.cpp Thu Aug 29 03:20:07 2013
> @@ -1870,9 +1870,6 @@ void Sema::DiagnoseAmbiguousLookup(Looku
>        Diag((*DI)->getLocation(), diag::note_ambiguous_candidate) << *DI;
>      break;
>    }
> -
> -  default:
> -    llvm_unreachable("unknown ambiguity kind");
>    }
>  }
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list