[PATCH] [ms-cxxabi] Implement guard variables for static initialization
Eli Friedman
eli.friedman at gmail.com
Wed Aug 28 17:51:27 PDT 2013
(Not a full review.)
The general approach to numbering seems fine.
================
Comment at: lib/Sema/SemaLambda.cpp:101
@@ -98,1 +100,3 @@
+ (isa<FunctionDecl>(CurContext) &&
+ Context.getTargetInfo().getCXXABI().isMicrosoft())) {
ManglingContextDecl = 0;
----------------
Why do you need to number anything in a function which isn't inline? CodeGen can mangle static variables etc. however it wants because they aren't externally visible.
http://llvm-reviews.chandlerc.com/D1416
More information about the cfe-commits
mailing list