[PATCH] Mostly correct conditional handling for Consumed analysis

Aaron Ballman aaron.ballman at gmail.com
Wed Aug 28 15:57:19 PDT 2013


The OwningPtr changes would be appropriate as a separate patch (esp
since the one this is based on is 1) pretty extensive, and 2) already
LGTMed, 3) the OwningPtr is really a distinct change).  Any chance you
can split those out?

~Aaron

On Wed, Aug 28, 2013 at 6:54 PM, Christian Wailes
<chriswailes at google.com> wrote:
>   Fixed some memory leaks with an OwningPtr.
>
> Hi delesley, dblaikie, aaron.ballman,
>
> http://llvm-reviews.chandlerc.com/D1501
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D1501?vs=3874&id=3877#toc
>
> Files:
>   include/clang/Analysis/Analyses/Consumed.h
>   lib/Analysis/Consumed.cpp
>   test/SemaCXX/warn-consumed-analysis-strict.cpp
>   test/SemaCXX/warn-consumed-analysis.cpp



More information about the cfe-commits mailing list