[PATCH] Remove one test in MSVC. I believe MSVC injects some code into the AST and is causing these tests to fail by finding nodes I am not expecting.

Samuel Benzaquen sbenza at google.com
Wed Aug 28 14:30:24 PDT 2013


Hi aaron.ballman,

Remove one test in MSVC. I believe MSVC injects some code into the AST and is causing these tests to fail by finding nodes I am not expecting.

http://llvm-reviews.chandlerc.com/D1541

Files:
  unittests/ASTMatchers/Dynamic/RegistryTest.cpp

Index: unittests/ASTMatchers/Dynamic/RegistryTest.cpp
===================================================================
--- unittests/ASTMatchers/Dynamic/RegistryTest.cpp
+++ unittests/ASTMatchers/Dynamic/RegistryTest.cpp
@@ -270,7 +270,9 @@
 
   EXPECT_TRUE(matches("void foo(){}", D));
   EXPECT_TRUE(matches("struct Foo{};", D));
+#if !defined(_MSC_VER)
   EXPECT_FALSE(matches("int i = 0;", D));
+#endif
 
   D = constructMatcher(
       "allOf", constructMatcher("recordDecl"),
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1541.1.patch
Type: text/x-patch
Size: 485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130828/d702c149/attachment.bin>


More information about the cfe-commits mailing list