r189516 - More comments for r189494.

David Blaikie dblaikie at gmail.com
Wed Aug 28 13:58:00 PDT 2013


Author: dblaikie
Date: Wed Aug 28 15:58:00 2013
New Revision: 189516

URL: http://llvm.org/viewvc/llvm-project?rev=189516&view=rev
Log:
More comments for r189494.

Modified:
    cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=189516&r1=189515&r2=189516&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Wed Aug 28 15:58:00 2013
@@ -1123,9 +1123,12 @@ CollectCXXMemberFunctions(const CXXRecor
   for(DeclContext::decl_iterator I = RD->decls_begin(),
         E = RD->decls_end(); I != E; ++I) {
     if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(*I)) {
-      // Reuse the existing member function declaration if it exists
+      // Reuse the existing member function declaration if it exists.
       // It may be associated with the declaration of the type & should be
       // reused as we're building the definition.
+      //
+      // This situation can arise in the vtable-based debug info reduction where
+      // implicit members are emitted in a non-vtable TU.
       llvm::DenseMap<const FunctionDecl *, llvm::WeakVH>::iterator MI =
           SPCache.find(Method->getCanonicalDecl());
       if (MI == SPCache.end()) {





More information about the cfe-commits mailing list