[PATCH] isCharInSet refactoring.

Richard Smith richard at metafoo.co.uk
Wed Aug 28 11:50:59 PDT 2013



================
Comment at: include/llvm/Support/UnicodeCharRanges.h:52-54
@@ -61,2 +51,5 @@
+  /// instances per each array of ranges, as possible.
+  UnicodeCharSet(CharRanges Ranges) : Ranges(Ranges) {
+    assert(rangesAreValid());
   }
 
----------------
It'd be great to make this `LLVM_CONSTEXPR` in the `NDEBUG` case, to avoid a guard variable for the static locals in Clang. (You'll also need to make the corresponding `ArrayRef` constructor be `LLVM_CONSTEXPR`.)


http://llvm-reviews.chandlerc.com/D1534

BRANCH
  svn

ARCANIST PROJECT
  llvm



More information about the cfe-commits mailing list