r189368 - Revert "Add support for eachOf/allOf/anyOf variadic matchers in the dynamic layer."
Samuel Benzaquen
sbenza at google.com
Tue Aug 27 09:55:22 PDT 2013
Author: sbenza
Date: Tue Aug 27 11:55:22 2013
New Revision: 189368
URL: http://llvm.org/viewvc/llvm-project?rev=189368&view=rev
Log:
Revert "Add support for eachOf/allOf/anyOf variadic matchers in the dynamic layer."
Summary:
This reverts commit 3b082a3c72324aa3363b5184731740534c6b9a2b.
It breaks the build in c++11 mode.
Reviewers: klimek
CC: cfe-commits, revane
Differential Revision: http://llvm-reviews.chandlerc.com/D1533
Modified:
cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h
cfe/trunk/lib/ASTMatchers/Dynamic/Marshallers.h
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
cfe/trunk/lib/ASTMatchers/Dynamic/VariantValue.cpp
cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp
cfe/trunk/unittests/ASTMatchers/Dynamic/RegistryTest.cpp
Modified: cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h?rev=189368&r1=189367&r2=189368&view=diff
==============================================================================
--- cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h (original)
+++ cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h Tue Aug 27 11:55:22 2013
@@ -50,10 +50,6 @@ class VariantMatcher {
public:
virtual ~MatcherOps();
virtual bool canConstructFrom(const DynTypedMatcher &Matcher) const = 0;
- virtual void constructFrom(const DynTypedMatcher &Matcher) = 0;
- virtual void constructVariadicOperator(
- ast_matchers::internal::VariadicOperatorFunction Func,
- ArrayRef<VariantMatcher> InnerMatchers) = 0;
};
/// \brief Payload interface to be specialized by each matcher type.
@@ -64,7 +60,9 @@ class VariantMatcher {
virtual ~Payload();
virtual bool getSingleMatcher(const DynTypedMatcher *&Out) const = 0;
virtual std::string getTypeAsString() const = 0;
- virtual void makeTypedMatcher(MatcherOps &Ops) const = 0;
+ virtual bool hasTypedMatcher(const MatcherOps &Ops) const = 0;
+ virtual const DynTypedMatcher *
+ getTypedMatcher(const MatcherOps &Ops) const = 0;
};
public:
@@ -80,13 +78,6 @@ public:
static VariantMatcher
PolymorphicMatcher(ArrayRef<const DynTypedMatcher *> Matchers);
- /// \brief Creates a 'variadic' operator matcher.
- ///
- /// It will bind to the appropriate type on getTypedMatcher<T>().
- static VariantMatcher VariadicOperatorMatcher(
- ast_matchers::internal::VariadicOperatorFunction Func,
- ArrayRef<VariantMatcher> Args);
-
/// \brief Makes the matcher the "null" matcher.
void reset();
@@ -110,9 +101,8 @@ public:
/// that can, the result would be ambiguous and false is returned.
template <class T>
bool hasTypedMatcher() const {
- TypedMatcherOps<T> Ops;
- if (Value) Value->makeTypedMatcher(Ops);
- return Ops.hasMatcher();
+ if (Value) return Value->hasTypedMatcher(TypedMatcherOps<T>());
+ return false;
}
/// \brief Return this matcher as a \c Matcher<T>.
@@ -121,10 +111,9 @@ public:
/// Asserts that \c hasTypedMatcher<T>() is true.
template <class T>
ast_matchers::internal::Matcher<T> getTypedMatcher() const {
- TypedMatcherOps<T> Ops;
- Value->makeTypedMatcher(Ops);
- assert(Ops.hasMatcher() && "hasTypedMatcher<T>() == false");
- return Ops.matcher();
+ assert(hasTypedMatcher<T>());
+ return ast_matchers::internal::Matcher<T>::constructFrom(
+ *Value->getTypedMatcher(TypedMatcherOps<T>()));
}
/// \brief String representation of the type of the value.
@@ -138,50 +127,13 @@ private:
class SinglePayload;
class PolymorphicPayload;
- class VariadicOpPayload;
template <typename T>
class TypedMatcherOps : public MatcherOps {
public:
- typedef ast_matchers::internal::Matcher<T> MatcherT;
-
virtual bool canConstructFrom(const DynTypedMatcher &Matcher) const {
- return MatcherT::canConstructFrom(Matcher);
- }
-
- virtual void constructFrom(const DynTypedMatcher& Matcher) {
- Out.reset(new MatcherT(MatcherT::constructFrom(Matcher)));
+ return ast_matchers::internal::Matcher<T>::canConstructFrom(Matcher);
}
-
- virtual void constructVariadicOperator(
- ast_matchers::internal::VariadicOperatorFunction Func,
- ArrayRef<VariantMatcher> InnerMatchers) {
- const size_t NumArgs = InnerMatchers.size();
- MatcherT **InnerArgs = new MatcherT *[NumArgs]();
- bool HasError = false;
- for (size_t i = 0; i != NumArgs; ++i) {
- // Abort if any of the inner matchers can't be converted to
- // Matcher<T>.
- if (!InnerMatchers[i].hasTypedMatcher<T>()) {
- HasError = true;
- break;
- }
- InnerArgs[i] = new MatcherT(InnerMatchers[i].getTypedMatcher<T>());
- }
- if (!HasError) {
- Out.reset(new MatcherT(
- new ast_matchers::internal::VariadicOperatorMatcherInterface<T>(
- Func, ArrayRef<const MatcherT *>(InnerArgs, NumArgs))));
- }
- std::for_each(InnerArgs, InnerArgs + NumArgs, llvm::deleter<MatcherT>);
- delete[] InnerArgs;
- }
-
- bool hasMatcher() const { return Out; }
- const MatcherT &matcher() const { return *Out; }
-
- private:
- OwningPtr<MatcherT> Out;
};
IntrusiveRefCntPtr<const Payload> Value;
Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Marshallers.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ASTMatchers/Dynamic/Marshallers.h?rev=189368&r1=189367&r2=189368&view=diff
==============================================================================
--- cfe/trunk/lib/ASTMatchers/Dynamic/Marshallers.h (original)
+++ cfe/trunk/lib/ASTMatchers/Dynamic/Marshallers.h Tue Aug 27 11:55:22 2013
@@ -348,36 +348,6 @@ private:
std::vector<MatcherCreateCallback *> Overloads;
};
-/// \brief Variadic operator marshaller function.
-class VariadicOperatorMatcherCreateCallback : public MatcherCreateCallback {
-public:
- typedef ast_matchers::internal::VariadicOperatorFunction VarFunc;
- VariadicOperatorMatcherCreateCallback(VarFunc Func, StringRef MatcherName)
- : Func(Func), MatcherName(MatcherName) {}
-
- virtual VariantMatcher run(const SourceRange &NameRange,
- ArrayRef<ParserValue> Args,
- Diagnostics *Error) const {
- std::vector<VariantMatcher> InnerArgs;
- for (size_t i = 0, e = Args.size(); i != e; ++i) {
- const ParserValue &Arg = Args[i];
- const VariantValue &Value = Arg.Value;
- if (!Value.isMatcher()) {
- Error->addError(Arg.Range, Error->ET_RegistryWrongArgType)
- << (i + 1) << "Matcher<>" << Value.getTypeAsString();
- return VariantMatcher();
- }
- InnerArgs.push_back(Value.getMatcher());
- }
- return VariantMatcher::VariadicOperatorMatcher(Func, InnerArgs);
- }
-
-private:
- const VarFunc Func;
- const StringRef MatcherName;
-};
-
-
/// Helper functions to select the appropriate marshaller functions.
/// They detect the number of arguments, arguments types and return type.
@@ -440,13 +410,6 @@ AdaptativeOverloadCollector<ArgumentAdap
collect(typename FromTypeList::tail());
}
-/// \brief Variadic operator overload.
-MatcherCreateCallback *makeMatcherAutoMarshall(
- ast_matchers::internal::VariadicOperatorMatcherFunc Func,
- StringRef MatcherName) {
- return new VariadicOperatorMatcherCreateCallback(Func.Func, MatcherName);
-}
-
} // namespace internal
} // namespace dynamic
} // namespace ast_matchers
Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp?rev=189368&r1=189367&r2=189368&view=diff
==============================================================================
--- cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp (original)
+++ cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Tue Aug 27 11:55:22 2013
@@ -77,6 +77,9 @@ RegistryMaps::RegistryMaps() {
//
// Polymorphic + argument overload:
// unless
+ // eachOf
+ // anyOf
+ // allOf
// findAll
//
// Other:
@@ -96,8 +99,6 @@ RegistryMaps::RegistryMaps() {
REGISTER_MATCHER(accessSpecDecl);
REGISTER_MATCHER(alignOfExpr);
- REGISTER_MATCHER(allOf);
- REGISTER_MATCHER(anyOf);
REGISTER_MATCHER(anything);
REGISTER_MATCHER(argumentCountIs);
REGISTER_MATCHER(arraySubscriptExpr);
@@ -140,7 +141,6 @@ RegistryMaps::RegistryMaps() {
REGISTER_MATCHER(destructorDecl);
REGISTER_MATCHER(doStmt);
REGISTER_MATCHER(dynamicCastExpr);
- REGISTER_MATCHER(eachOf);
REGISTER_MATCHER(elaboratedType);
REGISTER_MATCHER(enumConstantDecl);
REGISTER_MATCHER(enumDecl);
Modified: cfe/trunk/lib/ASTMatchers/Dynamic/VariantValue.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ASTMatchers/Dynamic/VariantValue.cpp?rev=189368&r1=189367&r2=189368&view=diff
==============================================================================
--- cfe/trunk/lib/ASTMatchers/Dynamic/VariantValue.cpp (original)
+++ cfe/trunk/lib/ASTMatchers/Dynamic/VariantValue.cpp Tue Aug 27 11:55:22 2013
@@ -38,9 +38,13 @@ public:
.str();
}
- virtual void makeTypedMatcher(MatcherOps &Ops) const {
- if (Ops.canConstructFrom(*Matcher))
- Ops.constructFrom(*Matcher);
+ virtual bool hasTypedMatcher(const MatcherOps &Ops) const {
+ return Ops.canConstructFrom(*Matcher);
+ }
+
+ virtual const DynTypedMatcher *getTypedMatcher(const MatcherOps &Ops) const {
+ assert(hasTypedMatcher(Ops));
+ return Matcher.get();
}
private:
@@ -76,49 +80,23 @@ public:
return (Twine("Matcher<") + Inner + ">").str();
}
- virtual void makeTypedMatcher(MatcherOps &Ops) const {
- const DynTypedMatcher *Found = NULL;
+ virtual bool hasTypedMatcher(const MatcherOps &Ops) const {
+ return getTypedMatcher(Ops) != NULL;
+ }
+
+ virtual const DynTypedMatcher *getTypedMatcher(const MatcherOps &Ops) const {
+ const DynTypedMatcher* Found = NULL;
for (size_t i = 0, e = Matchers.size(); i != e; ++i) {
if (Ops.canConstructFrom(*Matchers[i])) {
- if (Found)
- return;
+ if (Found) return NULL;
Found = Matchers[i];
}
}
- if (Found)
- Ops.constructFrom(*Found);
- }
-
- std::vector<const DynTypedMatcher *> Matchers;
-};
-
-class VariantMatcher::VariadicOpPayload : public VariantMatcher::Payload {
-public:
- VariadicOpPayload(ast_matchers::internal::VariadicOperatorFunction Func,
- ArrayRef<VariantMatcher> Args)
- : Func(Func), Args(Args) {}
-
- virtual bool getSingleMatcher(const DynTypedMatcher *&Out) const {
- return false;
- }
-
- virtual std::string getTypeAsString() const {
- std::string Inner;
- for (size_t i = 0, e = Args.size(); i != e; ++i) {
- if (i != 0)
- Inner += "&";
- Inner += Args[i].getTypeAsString();
- }
- return Inner;
- }
-
- virtual void makeTypedMatcher(MatcherOps &Ops) const {
- Ops.constructVariadicOperator(Func, Args);
+ return Found;
}
private:
- const ast_matchers::internal::VariadicOperatorFunction Func;
- const std::vector<VariantMatcher> Args;
+ std::vector<const DynTypedMatcher *> Matchers;
};
VariantMatcher::VariantMatcher() {}
@@ -132,12 +110,6 @@ VariantMatcher::PolymorphicMatcher(Array
return VariantMatcher(new PolymorphicPayload(Matchers));
}
-VariantMatcher VariantMatcher::VariadicOperatorMatcher(
- ast_matchers::internal::VariadicOperatorFunction Func,
- ArrayRef<VariantMatcher> Args) {
- return VariantMatcher(new VariadicOpPayload(Func, Args));
-}
-
bool VariantMatcher::getSingleMatcher(const DynTypedMatcher *&Out) const {
if (Value) return Value->getSingleMatcher(Out);
return false;
Modified: cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp?rev=189368&r1=189367&r2=189368&view=diff
==============================================================================
--- cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp (original)
+++ cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp Tue Aug 27 11:55:22 2013
@@ -137,9 +137,9 @@ bool matchesRange(const SourceRange &Ran
Range.Start.Column == StartColumn && Range.End.Column == EndColumn;
}
-const DynTypedMatcher *getSingleMatcher(const VariantValue &Value) {
+const DynTypedMatcher *getSingleMatcher(const VariantValue &value) {
const DynTypedMatcher *Out;
- EXPECT_TRUE(Value.getMatcher().getSingleMatcher(Out));
+ EXPECT_TRUE(value.getMatcher().getSingleMatcher(Out));
return Out;
}
Modified: cfe/trunk/unittests/ASTMatchers/Dynamic/RegistryTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/Dynamic/RegistryTest.cpp?rev=189368&r1=189367&r2=189368&view=diff
==============================================================================
--- cfe/trunk/unittests/ASTMatchers/Dynamic/RegistryTest.cpp (original)
+++ cfe/trunk/unittests/ASTMatchers/Dynamic/RegistryTest.cpp Tue Aug 27 11:55:22 2013
@@ -261,33 +261,6 @@ TEST_F(RegistryTest, Adaptative) {
EXPECT_FALSE(matches("void foo() { if (true) return; }", S));
}
-TEST_F(RegistryTest, VariadicOp) {
- Matcher<Decl> D = constructMatcher(
- "anyOf", constructMatcher("recordDecl"),
- constructMatcher("namedDecl",
- constructMatcher("hasName", std::string("foo"))))
- .getTypedMatcher<Decl>();
-
- EXPECT_TRUE(matches("void foo(){}", D));
- EXPECT_TRUE(matches("struct Foo{};", D));
- EXPECT_FALSE(matches("int i = 0;", D));
-
- D = constructMatcher(
- "allOf", constructMatcher("recordDecl"),
- constructMatcher(
- "namedDecl",
- constructMatcher("anyOf",
- constructMatcher("hasName", std::string("Foo")),
- constructMatcher("hasName", std::string("Bar")))))
- .getTypedMatcher<Decl>();
-
- EXPECT_FALSE(matches("void foo(){}", D));
- EXPECT_TRUE(matches("struct Foo{};", D));
- EXPECT_FALSE(matches("int i = 0;", D));
- EXPECT_TRUE(matches("class Bar{};", D));
- EXPECT_FALSE(matches("class OtherBar{};", D));
-}
-
TEST_F(RegistryTest, Errors) {
// Incorrect argument count.
OwningPtr<Diagnostics> Error(new Diagnostics());
@@ -312,24 +285,6 @@ TEST_F(RegistryTest, Errors) {
EXPECT_EQ("Incorrect type for arg 2. (Expected = Matcher<CXXRecordDecl>) != "
"(Actual = Matcher<FunctionDecl>)",
Error->toString());
-
- // Bad argument type with variadic.
- Error.reset(new Diagnostics());
- EXPECT_TRUE(constructMatcher("anyOf", std::string(), Error.get()).isNull());
- EXPECT_EQ(
- "Incorrect type for arg 1. (Expected = Matcher<>) != (Actual = String)",
- Error->toString());
- Error.reset(new Diagnostics());
- EXPECT_TRUE(constructMatcher(
- "recordDecl",
- constructMatcher("allOf",
- constructMatcher("isDerivedFrom", std::string("FOO")),
- constructMatcher("isArrow")),
- Error.get()).isNull());
- EXPECT_EQ("Incorrect type for arg 1. "
- "(Expected = Matcher<CXXRecordDecl>) != "
- "(Actual = Matcher<CXXRecordDecl>&Matcher<MemberExpr>)",
- Error->toString());
}
} // end anonymous namespace
More information about the cfe-commits
mailing list