[PATCH] clang-replace: Delete change description files

Tareq A. Siraj tareq.a.siraj at intel.com
Mon Aug 26 07:38:17 PDT 2013



================
Comment at: clang-replace/tool/ClangReplaceMain.cpp:28
@@ -27,1 +27,3 @@
 
+static cl::opt<bool> RemoveTUReplacementFiles(
+    "remove-change-desc-files",
----------------
Edwin Vane wrote:
> I thought the point was to remove files only if everything *was* successfully applied? Default behaviour should be no deletion. A command line switch indicates it's ok to delete files if everything applied cleanly.
>From cpp11-migrate's point of view, if there is a merge conflict, the user fixes the code manually after seeing the report on the console. If we don't delete change description files regardless of success, the user will have to delete these files manually. Is that what we are looking for (thinking about the "lazy typer" case)?


http://llvm-reviews.chandlerc.com/D1492



More information about the cfe-commits mailing list