[PATCH] Sema: Properly support Microsoft-mode template arguments

Chandler Carruth chandlerc at google.com
Fri Aug 23 01:57:23 PDT 2013


On Aug 22, 2013 9:11 PM, "Doug Gregor" <dgregor at apple.com> wrote:
>
>
>
> ================
> Comment at: lib/Sema/SemaTemplate.cpp:4177
> @@ +4176,3 @@
> +    SourceLocation FirstOpLoc;
> +    while (UnaryOperator *UnOp = dyn_cast<UnaryOperator>(Arg)) {
> +      UnaryOperatorKind UnOpKind = UnOp->getOpcode();
> ----------------
> Do we really want to strip of all of these &/* operators without even an
extension warning?

Agreed. I've said it in other contexts, but to reiterate: when adding
compatibility for non standard features like this, we need extension
warnings. When the features are actively broken by design for some inputs,
we need a "known buggy" warning (I'm looking at you record layout....
::shudder:: )

>
>
> http://llvm-reviews.chandlerc.com/D1444
>
> BRANCH
>   PR16905
>
> ARCANIST PROJECT
>   clang
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130823/93cc49ce/attachment.html>


More information about the cfe-commits mailing list