[PATCH] clang-replace: Write merged changes to disk
Edwin Vane
edwin.vane at intel.com
Thu Aug 22 05:34:24 PDT 2013
================
Comment at: clang-replace/ApplyReplacements.cpp:210
@@ +209,3 @@
+ if (!ErrorInfo.empty()) {
+ errs() << "Unable to open " << FileName << " for writing\n";
+ return false;
----------------
Manuel Klimek wrote:
> Since we're already using Diagnostics for everything else, might it make sense to use them here, too?
Actually, we're not actually using Diagnostics yet:) It's just passed around with the intention of using it. I have to look into how to do error reporting with a DiagnosticsEngine yet.
http://llvm-reviews.chandlerc.com/D1460
BRANCH
apply_changes
ARCANIST PROJECT
clang-tools-extra
More information about the cfe-commits
mailing list